Skip to content

SMT2 parser: add abbreviated versions of the rounding modes #8539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2025
Merged

SMT2 parser: add abbreviated versions of the rounding modes #8539

merged 1 commit into from
Jan 2, 2025

Conversation

@kroening
Copy link
Collaborator

@kroening kroening commented Dec 21, 2024

This adds RNE, RNA, RTP, RTN, RTZ as abbreviated versions of the rounding modes.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening
SMT2 parser: add abbreviated versions of the rounding modes
03ac764 
This adds RNE, RNA, RTP, RTN, RTZ as abbreviated versions of the rounding
modes.
@kroening kroening marked this pull request as ready for review December 21, 2024 22:07
@codecov
Copy link

codecov bot commented Dec 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 39.13043% with 14 lines in your changes missing coverage. Please review.

Project coverage is 78.53%. Comparing base (d5cf498) to head (03ac764).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
src/solvers/smt2/smt2_parser.cpp 39.13% 14 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #8539      +/-   ##
===========================================
- Coverage    78.58%   78.53%   -0.05%     
===========================================
  Files         1729     1729              
  Lines       199635   199772     +137     
  Branches     18311    18311              
===========================================
+ Hits        156887   156896       +9     
- Misses       42748    42876     +128

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening assigned kroening and peterschrammel and unassigned kroening Dec 27, 2024
@peterschrammel peterschrammel removed their assignment Jan 2, 2025
@kroening kroening merged commit 1102fa1 into develop Jan 2, 2025
37 of 41 checks passed
@kroening kroening deleted the smt2-rounding-modes branch January 2, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterschrammel peterschrammel peterschrammel approved these changes

@martin-cs martin-cs Awaiting requested review from martin-cs martin-cs is a code owner

@TGWDB TGWDB Awaiting requested review from TGWDB TGWDB is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kroening @peterschrammel